docs(i18n): copy edits to internationalization cookbook #2980
Conversation
|
@wardbell can we get this ASAP? I would like to work on the chapter for new features, soon. |
There was a problem hiding this comment.
LGTM except for
- the Spanish subhead which should read "Translate text messages"
- the comma before ", too" (see note)
I don't understand why the editor added more line breaks, sometimes beginning a line with a single word from the previous sentence. I would not do that and am likely to fix that if I stumble across it myself.
But that's not important here. Just the 2 requested fixes. Thanks.
| * [Use the **_ng-xi18n_ extraction tool** to create a translation source file](#ng-xi18n) | ||
| * [Translate](#translate) | ||
| * [Create a translation source file with the **_ng-xi18n_ extraction tool**](#ng-xi18n) | ||
| * [Translate los mensajes de texto](#translate) |
There was a problem hiding this comment.
This should stay in English: "Translate text messages". The Spanish was cute but inconsistent. Let's fix the actual subhead too.
| The application displays different text depending upon whether the hero is male or female. | ||
| These text alternatives require translation too. | ||
| These text alternatives require translation, too. |
There was a problem hiding this comment.
Why the comma? A comma in that position indicates a pause. Would you pause as in "... require translation ... ... ... too"? Who speaks like that? Please remove it or explain.
There was a problem hiding this comment.
My mistake. I thought that was the rule but on looking it up it looks like your way is the right way. Removed.
| @@ -272,15 +278,17 @@ code-example(language="sh" class="code-shell"). | |||
| npm run i18n -- --i18nFormat=xmb -p path/to/tsconfig.json | |||
| :marked | |||
| Note the `--` flag before the options. | |||
| It tells _npm_ that every flag thereafter should be passed through to `ng-xi18n`. | |||
| It tells _npm_ to pass every flag thereafter to `ng-xi18n`. | |||
There was a problem hiding this comment.
Oh my. Why did I write the passive? Thanks for fixing.
Shannon's copy edits to Internationalization.